Upgrade Font Awesome to 5.12 #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinRenou <martin.renou@gmail.com>
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
I wonder if the CI error is related, I don't really get the error message |
Not likely. That test fails a lot on windows. I'll leave this open for a day for anybody else to chime in. If there are no objections, I'll merge. I think it's a great idea to update fontawesome. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR takes over #7754 and is related to jupyter-widgets/ipywidgets#2698
Code changes
Upgrade Font Awesome to 5.12
Backwards-incompatible changes
This should no be backwards-incompatible as we include the v4-shim CSS which adds support for v4 class names in v5.