WIP - Remove font-awesome #7754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinRenou <martin.renou@gmail.com>
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
I put this in WIP for now, as it might need some discussions. Also, we might want to do an |
|
Heads up: the filebrowser example (in |
|
I believe a lot of plugins assume it's there |
|
Ok, so I guess we can't remove it then. Do you think it would be good to update the FontAwesome version at least? |
That would be super helpful! |
This was referenced Jan 10, 2020
|
Closed by #7769 |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR is kind-of related to jupyter-widgets/ipywidgets#2698. Looking at the code, I suspect font-awesome is not used in JupyterLab. I guess
ipywidgetswas lucky it was included though.Code changes
Simply removing font-awesome