Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give kernel connection options to a session connection #7820

Merged
merged 3 commits into from Jan 24, 2020
Merged

Give kernel connection options to a session connection #7820

merged 3 commits into from Jan 24, 2020

Commits on Jan 24, 2020

  1. Make sessionConnection take options for the kernel connection. 

    Right now this is just handleComms, but it may grow in the future.
    @jasongrout
    jasongrout committed Jan 24, 2020
    Copy the full SHA
    217b827 View commit details
    Browse the repository at this point in the history

  2. Make sure the help menu extension never claims it can handle comms.

    @jasongrout
    jasongrout committed Jan 24, 2020
    Copy the full SHA
    48d95f8 View commit details
    Browse the repository at this point in the history

  3. Shorten the logic slightly with optional chaining.

    @jasongrout
    jasongrout committed Jan 24, 2020
    Copy the full SHA
    9aecd51 View commit details
    Browse the repository at this point in the history