Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IFuture done typings more correct #8032

Merged
merged 1 commit into from Mar 12, 2020
Merged

Make IFuture done typings more correct #8032

merged 1 commit into from Mar 12, 2020

Commits on Mar 11, 2020

  1. Make IFuture done typings more correct 

    The kernel IFuture done promise never returns undefined in practice (since every shell/control message has a reply, which is needed for the done promise to even resolve), so we strengthen the typing in the interface.

This means that things relying on the done resolution do not have to check to see if the value is undefined from a typing perspective.
    @jasongrout
    jasongrout committed Mar 11, 2020
    Copy the full SHA
    2f18043 View commit details
    Browse the repository at this point in the history