Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update throttler API #54

Merged
merged 8 commits into from Mar 22, 2020
Merged

Update throttler API #54

merged 8 commits into from Mar 22, 2020

Conversation

afshin
Copy link
Member

@afshin afshin commented Feb 20, 2020 •
edited

  1. Move Poll tests to poll.spec.ts.
  2. Update Throttler to support leading and trailing configuration.
  3. Write tests for Debouncer and Throttler in ratelimiter.spec.ts.

Notes to reviewer(s):

  • The tests in poll.spec.ts are unchanged, they used to exist in index.spec.ts. Only the ratelimiter.spec.ts tests are new.
  • This API change requires a minor version bump.

cf. #51, jupyterlab/jupyterlab#7895

@afshin afshin changed the title [WIP] Update throttler API Update throttler API Feb 22, 2020
@afshin afshin added the enhancement New feature or request label Feb 22, 2020
ikiw pushed a commit to ikiw/jupyterlab that referenced this pull request Feb 23, 2020
Use throttler api with reference to jupyterlab/lumino#54
bf9bfdd
@ikiw ikiw mentioned this pull request Feb 25, 2020
Merged
@afshin afshin changed the title Update throttler API WIP: Update throttler API Mar 8, 2020
@afshin afshin changed the title WIP: Update throttler API Update throttler API Mar 8, 2020
blink1073
blink1073 approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c5a025c into jupyterlab:master Mar 22, 2020
@blink1073
Copy link
Member

https://github.com/jupyterlab/lumino/blob/master/CHANGELOG.md#2020-03-22

@blink1073 blink1073 mentioned this pull request Mar 28, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ikiw ikiw ikiw left review comments

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afshin @blink1073 @ikiw