Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to lodash 4.5.0 #212

Closed
wants to merge 3 commits into from
Closed

Conversation

dwatling
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dwatling
Copy link
Contributor Author

I signed it!

Also, I tried to read the guidelines about submitting PRs but the link was dead. Let me know what I need to do to make this PR better.

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks, can you please update the commit message to follow our convention

dwatling pushed a commit to dwatling/karma-coverage that referenced this pull request Feb 24, 2016
@dwatling
Copy link
Contributor Author

I'm not sure why the commit history on this branch became polluted with extraneous commits. I'll open a new PR with just the commit that includes the fixes and is formatted according to the convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants