-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use skopeo to preserve multi-arch lists during the tag operation #4592
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
============================================
- Coverage 88.16% 88.15% -0.01%
Complexity 8781 8781
============================================
Files 784 784
Lines 29361 29361
============================================
- Hits 25885 25883 -2
- Misses 3476 3478 +2 |
Ok, I did some reading (as I never heard about skopeo), but it sounds like a good idea. The I give my approval. @tobybatch any input / objections from your end? |
Yes, if it can help this is a question about this topic on stackoverflow. With the current runner/actions I think that the only available options are In any case before approving this change I think that it's better that @tobybatch tests it locally, otherwise in case of any issues this will break the release (it wasn't possible for me to test the E2E so I'm trusting the documentation of skopeo and the sourcecode of the docker login action, for the fact that skopeo will be able to do the push). |
We will see about this. But after a good result with the flag |
@tobybatch I can only look as such stuff from a bird view. Can you review please? |
|
Description
This is an attempt to resolve #4591 using skopeo instead of docker: skopeo has the capability to clone list of images.
ubuntu-latest runner that Kimai is actually using comes with skopeo already preinstalled and skopeo should fallback to credentials created in step Login to DockerHub.
Before approving this PR, @tobybatch or @kevinpapst should verifiy that everything is fine because I'm not able to test a complete workflow.
Types of changes
Checklist
composer code-check
)