Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for nesting this addon #27

Merged
merged 1 commit into from Feb 21, 2016
Merged

Conversation

mattxyzeth
Copy link
Contributor

If this addon is used within another addon, an error is thrown about not being able to find the options hash on the app. Please see ember-cli/ember-cli#3718

If this addon is used within another addon, an error is thrown about not being able to find the options hash on the app. Please see ember-cli/ember-cli#3718.
@CAH-MaggieRoss
Copy link

Would really like to see this resolved--we're cleaning up our devDependencies and want to move this to regular dependencies so we can just include it once in our internal addon instead of having to include it in each app we use the addon in.

@kimroen
Copy link
Owner

kimroen commented Feb 21, 2016

Hi! Thanks very much for looking in to this.

I see the canary test is failing, but it doesn't seem related, so I'll merge this, figure out the tests, and then release it when everything is passing.

I was hoping there would be a more permanent solution for this issue, but it looks like this hotfix is the best option for now.

Thanks for being patient with me, I really appreciate your help.

kimroen added a commit that referenced this pull request Feb 21, 2016
Adding support for nesting this addon
@kimroen kimroen merged commit 2116e04 into kimroen:master Feb 21, 2016
@RobbieTheWagner
Copy link

Can you guys please elaborate how to use this in an addon? I assume I have to put options in index.js but it doesn't seem to prefix anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants