run autoprefix before asset fingerprinting #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 - Thanks for tracking this down! |
|
Should we add that ember-cli-autoprefixer should also run before ember-cli-sri as I think a very similar issue is happening there. |
cbrevdev
force-pushed
the
autoprefix-order
branch
from
966ae5d
to
3284f61
Compare
|
Added ember-cli-sri to the before list. I'm now wondering whether we should also be adding an entry to the broccoli-asset-rev project to be explicitly before ember-cli-sri? Either that, or modify ember-cli-sri to have broccoli-asset-rev be after... |
|
It kind of sounds like we might be missing a logical step in asset generation; both of these want to run after the contents of the assets have "settled", so to speak. I'm happy to merge these to avoid the issue here, though. Thank you very much! |
kimroen
added a commit
that referenced
this pull request
Sep 19, 2017
|
Thanks again, this has been released as version 0.8.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember addon dependency to run before broccoli-asset-rev.
Addressing #38