Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Update magetasks & dependencies, rm LICENSE files #339

Merged
merged 6 commits into from Mar 28, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Mar 26, 2024

Changes

/kind cleanup

Closes #333

Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 26, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@cardil cardil marked this pull request as draft March 26, 2024 19:42
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 12.72727% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 53.16%. Comparing base (95d61bd) to head (565965f).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/cli/ics/encoding.go 0.00% 7 Missing ⚠️
pkg/k8s/kubeclient.go 0.00% 7 Missing ⚠️
pkg/k8s/jobrunner.go 0.00% 6 Missing ⚠️
pkg/cli/create.go 50.00% 5 Missing ⚠️
pkg/cli/ics/send.go 0.00% 4 Missing ⚠️
pkg/tests/cloudevent_server.go 0.00% 3 Missing ⚠️
internal/cli/cmd/build.go 0.00% 2 Missing ⚠️
internal/cli/cmd/send.go 0.00% 2 Missing ⚠️
pkg/k8s/addressresolver.go 0.00% 2 Missing ⚠️
pkg/sender/in_cluster.go 33.33% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   53.16%   53.16%           
=======================================
  Files          51       51           
  Lines        1580     1580           
=======================================
  Hits          840      840           
  Misses        671      671           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil cardil marked this pull request as ready for review March 27, 2024 14:11
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@cardil cardil changed the title 🧹 Update magetasks & dependencies 🧹 Update magetasks & dependencies, rm LICENSE files Mar 27, 2024
build/go.mod Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@cardil
Copy link
Contributor Author

cardil commented Mar 28, 2024

/cc @dsimansk

@knative-prow knative-prow bot requested a review from dsimansk March 28, 2024 15:41
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link

knative-prow bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@cardil
Copy link
Contributor Author

cardil commented Mar 28, 2024

/override codecov/patch

That Codecov is weird!

Copy link

knative-prow bot commented Mar 28, 2024

@cardil: Overrode contexts on behalf of cardil: codecov/patch

In response to this:

/override codecov/patch

That Codecov is weird!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 768caf4 into knative-extensions:main Mar 28, 2024
25 of 26 checks passed
@cardil cardil deleted the chore/update-magetasks branch March 28, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants