🧹 Use knative.dev/toolbox/magetasks #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
the
kind/cleanup
knative-prow
bot
added
approved
cardil
commented
Apr 11, 2024
knative-prow
bot
added
the
do-not-merge/hold
cardil
force-pushed
the
bugfix/knative-magetasks
branch
from
d0134ba
to
1a6dab7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 53.16% 55.67% +2.51%
==========================================
Files 51 51
Lines 1580 1374 -206
==========================================
- Hits 840 765 -75
+ Misses 671 540 -131
Partials 69 69 ☔ View full report in Codecov by Sentry. |
|
/test all |
cardil
force-pushed
the
bugfix/knative-magetasks
branch
from
1a6dab7
to
7b01c62
Compare
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
removed
the
do-not-merge/hold
cardil
force-pushed
the
bugfix/knative-magetasks
branch
from
7b01c62
to
a50d2fe
Compare
knative-prow
bot
removed
the
do-not-merge/work-in-progress
knative-prow-robot
removed
the
needs-rebase
knative-prow
bot
added
size/XL
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cardil
added a commit
to cardil/kn-plugin-event
that referenced
this pull request
May 6, 2024
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-event
that referenced
this pull request
May 6, 2024
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/kn-plugin-event
that referenced
this pull request
May 7, 2024
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-event
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind cleanup
Fixes #338