Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💝 Handover of magetasks to Knative project #28

Merged
merged 6 commits into from Apr 12, 2024
Merged

💝 Handover of magetasks to Knative project #28

merged 6 commits into from Apr 12, 2024
+9,893 −2,737

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Apr 11, 2024

Which issue(s) this PR fixes:

Fixes knative-extensions/kn-plugin-event#338

Changes

  • 💝 Handover of magetasks to Knative project

/kind enhancement

@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Apr 11, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2024
@cardil
Merge remote-tracking branch 'upstream/main' into handover/magetasks
caf3747 
Conflicts fixed:

 - .editorconfig
 - go.work
 - go.work.sum
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/test all

@cardil cardil marked this pull request as ready for review April 11, 2024 19:46
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/hold

To be tested against kn-plugin-event

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@cardil cardil mentioned this pull request Apr 11, 2024
Merged
@cardil
Copy link
Contributor Author

cardil commented Apr 12, 2024

/cc @dsimansk

It work with kn-event, as seen in knative-extensions/kn-plugin-event#345

/unhold

@knative-prow knative-prow bot requested a review from dsimansk April 12, 2024 07:02
@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@dsimansk
Copy link
Contributor

/approve
/lgtm

Adding hold for Productivity WG, @upodroid to check. Or it that's already discussed, @cardil feel free to unhold.
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
upodroid
upodroid approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke about this yesterday. +1
/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cardil,dsimansk,upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 703489d into knative:main Apr 12, 2024
23 checks passed
@cardil cardil deleted the handover/magetasks branch April 12, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@psschwei psschwei Awaiting requested review from psschwei

@evankanderson evankanderson Awaiting requested review from evankanderson

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dsimansk dsimansk

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mage tasks should be under Knative control
4 participants
@cardil @dsimansk @upodroid @knative-prow-robot