Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressBar can hang forever while stopping, when executed on fast rendering setups #161

Closed
cardil opened this issue Mar 21, 2024 · 0 comments · Fixed by #162
Closed

ProgressBar can hang forever while stopping, when executed on fast rendering setups #161

cardil opened this issue Mar 21, 2024 · 0 comments · Fixed by #162
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Mar 21, 2024

On some fast rendering setups like:

  • unit tests,
  • background processes,
  • pipe'ing output/input

the spinner could hang indefinitely on Wait(), and <-b.ended method:

client-pkg/pkg/output/tui/progress.go

Lines 255 to 257 in 325b48c

b.tea.Wait()
<-b.ended

See the goroutines dump: https://gist.github.com/cardil/7fa34571b0dc0770113b5ff707f84841

/kind bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐞 Fix the hang of the spinner and progress bar on stop cardil/knative-client-pkg
1 participant
@cardil