Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emeritus WGs from Peribolos #1547

Merged
merged 1 commit into from Mar 27, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Mar 26, 2024

Changes

  • Remove emeritus WGs from Peribolos

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Mar 26, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Remove emeritus WGs from Peribolos

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2024
@aliok
Copy link
Member Author

aliok commented Mar 26, 2024

@cardil @upodroid

I am not 100% sure if the removed things are referenced in any repos. Can they be used in the OWNERS files in repositories? Or, do we manage those files based on the files here and this PR will be just fine?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@cardil
Copy link
Contributor

cardil commented Mar 26, 2024

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@cardil
Copy link
Contributor

cardil commented Mar 26, 2024

@aliok: I am not 100% sure if the removed things are referenced in any repos. Can they be used in the OWNERS files in repositories? Or, do we manage those files based on the files here and this PR will be just fine?

I think only OWNER_ALIASES is synched. The OWNERS file needs to be adjusted if those removed teams are used. IDK, if it will break Prow review suggestions, but I doubt it.

@aliok
Copy link
Member Author

aliok commented Mar 26, 2024

The OWNERS file needs to be adjusted if those removed teams are used. IDK, if it will break Prow review suggestions, but I doubt it.

Do I need to go and check each repo to find out where these deleted teams are used? Or will it be "only" review suggestions that might be broken. If it is the latter, I would want to merge this PR and send an email to knative-dev asking folks to check their own repositories.

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1177cc1 into knative:main Mar 27, 2024
6 checks passed
@aliok aliok deleted the 2024-03-26-remove-emeritus-groups branch March 29, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants