Fix SQLite not doing rollback when altering columns fails #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kibertoad Finishing #4189 is my next top priority, but I will be busy with personal things for at least 1-2 weeks. Implementing the SQL part, modifying the runner to execute queries on a transaction and writing tests will then take at least a few days depending on how things go. So, I don't think it would be worth it to delay the release. |
kibertoad
approved these changes
Mar 3, 2021
nickrum
added a commit
to nickrum/knex
that referenced
this pull request
Dec 15, 2021
nickrum
added a commit
to nickrum/knex
that referenced
this pull request
Dec 15, 2021
kibertoad
pushed a commit
that referenced
this pull request
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statements produced by the statements producer are currently not executed inside a transaction, which means that the changes are not rolled back if an error occurs. This will be fixed by #4189, but I won't find the time to finish that PR before the
0.95.0release. Once it's done, this change can be reverted.