New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
response.redirect: extract special-cased back, fixes #904 #1115
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 393 398 +5
======================================
+ Hits 393 398 +5
Continue to review full report at Codecov.
|
I'm assuming this is a travis-cache thingie that fails, can't reproduce it locally. $ git rev-parse --abbrev-ref HEAD
refactor-back
$ node -v
v9.3.0
$ npm -v
5.6.0
$ npm view koa version
2.4.1
$ npm t
# abbreviated jest output
Test Suites: 66 passed, 66 total
Tests: 298 passed, 298 total
Snapshots: 0 total
Time: 2.265s
Ran all test suites. |
👍 let's add this as a feature + deprecation message, then a separate PR to remove it in the next major version |
cad890c
to
ac6bef5
Compare
@jonathanong updated, and should be safe as a semver-minor merge. Just take a quick look at the deprecation message before doing so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I believe that should be merged this PR 🚀
The simple solution to drop special-cased
'back'
inresponse.redirect
.I can't label but should be labeled as version-major.
This PR does not make use of Symbol as purposed in #904.
Edit
If this solution is acceptable, a deprecation should be added to Koa 2 on
'back'
use.