Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Angular Material components to version 15 #5864

Closed
22 tasks done
Waseem826 opened this issue Mar 29, 2023 · 1 comment · Fixed by #6685
Closed
22 tasks done

Migrate Angular Material components to version 15 #5864

Waseem826 opened this issue Mar 29, 2023 · 1 comment · Fixed by #6685
Assignees
Labels
Epic kind/chore Updating grunt tasks etc; no production code changes. priority/high sig/ui Denotes a PR or issue as being assigned to SIG UI.

Comments

@Waseem826
Copy link
Contributor

Waseem826 commented Mar 29, 2023

Angular was upgraded to version 15 in #5335. However, Angular Material components were not migrated since it required extra effort and could've caused breaking changes.
So as part of this epic we should migrate each Angular Material component individually from legacy to v15 by following instructions in https://github.com/angular/components/blob/main/guides/v15-mdc-migration.md.

Tasks

  1. kind/chore sig/ui
    Waseem826
  2. approved dco-signoff: yes docs/none kind/design lgtm release-note-none size/M
    Waseem826 ahmedwaleedmalik

After migration, make sure that all overridden CSS styles are also updated and work as expected.

@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Mar 22, 2024

#6629 takes care of migrations but we still need to refactor, fix the components a bit. Let's do that one by one.

The unit tests need to be fixed against this ticket as they were marked as optional in #6629

There is some issue here as well that needs investigation, https://github.com/kubermatic/dashboard/pull/6629/files#diff-61d4fb972cb546cef71307d8e53a72ef81dd80ea0ce4c376ad801587f04b770aR112-R144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic kind/chore Updating grunt tasks etc; no production code changes. priority/high sig/ui Denotes a PR or issue as being assigned to SIG UI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants