Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate card-chip component version 15 #6655

Merged

Conversation

ahmadhamzh
Copy link
Contributor

What this PR does / why we need it:
migrates Angular Material card and chip components from legacy to v15.
Which issue(s) this PR fixes:
xref #5864

What type of PR is this?
/kind chore

NONE
NONE

@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2024
@kubermatic-bot
Copy link
Contributor

@ahmadhamzh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-web-unit 61b949b link false /test pre-dashboard-web-unit

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve ⭐

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54668bef876c51e2496c3f33a223726fde7a188a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@kubermatic-bot kubermatic-bot merged commit 67f5293 into kubermatic:main Apr 16, 2024
7 of 8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone Apr 16, 2024
ahmadhamzh added a commit to ahmadhamzh/dashboard that referenced this pull request Apr 29, 2024
kubermatic-bot pushed a commit that referenced this pull request Apr 30, 2024
* Migrate form-field and tool-tip component version 15 (#6655)

* Migrate mat-select component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants