Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Angular Material progress bar and progress spinner components from legacy to v15 #6002

Merged
merged 2 commits into from
May 31, 2023
Merged

Migrate Angular Material progress bar and progress spinner components from legacy to v15 #6002

merged 2 commits into from
May 31, 2023

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:
This PR migrates Angular Material progress bar and progress spinner components from legacy to v15.

Which issue(s) this PR fixes:

xref #5864

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@Waseem826 Waseem826 self-assigned this May 31, 2023
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2023
@Waseem826 Waseem826 mentioned this pull request May 31, 2023
Closed
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 36dc9f581c575cb20aae441a1a19461c21a775c7

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Waseem826
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 86e1179 into kubermatic:main May 31, 2023
9 of 10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 31, 2023
@Waseem826 Waseem826 deleted the migrate-material-progress-bar-and-spinner-components branch June 5, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik