Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update non-Kubernetes Go dependencies #11604

Merged
merged 2 commits into from Dec 28, 2022
Merged

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Dec 28, 2022

What this PR does / why we need it:
This is some end-of-year holiday dependency bumping, so we can start fresh into 2023. I included a new replace directive to make my update checker script work. Without the new directive, go list -u -m -json all would fail with

go: github.com/optiopay/kafka@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

I didn't update go-git to 5.5.1 as they have removed the option to override the HostKeyCallback (see go-git/go-git#548), which could impact our controllers and I would rather defer this to SIG App Mngt.

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 28, 2022
@xrstf xrstf requested a review from xmudrii December 28, 2022 17:47
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8273b80e246a2b1b364ba50af9b7850f2de0821

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf
Copy link
Contributor Author

xrstf commented Dec 28, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit 2fa3f8f into kubermatic:main Dec 28, 2022
@xrstf xrstf deleted the bump-deps branch January 24, 2023 10:23
@xrstf xrstf mentioned this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants