Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added Encoder Config Options field. #915

Merged
merged 1 commit into from Aug 18, 2020
Merged

✨ Added Encoder Config Options field. #915

merged 1 commit into from Aug 18, 2020

Conversation

bharathi-tenneti
Copy link
Contributor

@bharathi-tenneti bharathi-tenneti commented Apr 22, 2020 •
edited

Description: This PR adds field in Options struct, for adding Encoder configuration options programmatically.

Motivation: This will make it easier for operator developers to specify different Encoder options.

Fixes: #912

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bharathi-tenneti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2020
@bharathi-tenneti
Copy link
Contributor Author

@hasbro17

hasbro17
hasbro17 suggested changes Apr 22, 2020
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2020
@joelanford
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2020
hasbro17
hasbro17 suggested changes Apr 27, 2020
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
hasbro17
hasbro17 suggested changes Apr 27, 2020
View reviewed changes
pkg/log/zap/flags.go Outdated Show resolved Hide resolved
hasbro17
hasbro17 approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after returning an error for invalid flag values.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2020
@bharathi-tenneti
Copy link
Contributor Author

/retest

joelanford
joelanford reviewed Apr 30, 2020
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
estroz
estroz reviewed May 4, 2020
View reviewed changes
pkg/log/zap/flags.go Outdated Show resolved Hide resolved
estroz
estroz reviewed May 4, 2020
View reviewed changes
pkg/log/zap/flags.go Outdated Show resolved Hide resolved
estroz
estroz reviewed May 4, 2020
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
estroz
estroz reviewed May 4, 2020
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
hasbro17
hasbro17 reviewed May 5, 2020
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
@bharathi-tenneti bharathi-tenneti changed the title ✨Added TimeEncoder flag and helper functions ✨Added Encoder Config Options field. Jul 22, 2020
@bharathi-tenneti bharathi-tenneti changed the title ✨Added Encoder Config Options field. ✨<WIP> Added Encoder Config Options field. Jul 22, 2020
@bharathi-tenneti
Copy link
Contributor Author

This PR is being re-worked to add Encoder Config Options , rather than specific time encoder flag, seen in the earlier implementations.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharathi-tenneti, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bharathi-tenneti bharathi-tenneti changed the title ✨<WIP> Added Encoder Config Options field. ✨ Added Encoder Config Options field. Jul 23, 2020
@bharathi-tenneti
Copy link
Contributor Author

/retest

4 similar comments
@bharathi-tenneti
Copy link
Contributor Author

/retest

@bharathi-tenneti
Copy link
Contributor Author

/retest

@bharathi-tenneti
Copy link
Contributor Author

/retest

@bharathi-tenneti
Copy link
Contributor Author

/retest

joelanford
joelanford requested changes Jul 27, 2020
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
pkg/log/zap/zap_test.go Outdated Show resolved Hide resolved
pkg/log/zap/zap_test.go Outdated Show resolved Hide resolved
pkg/log/zap/zap_test.go Outdated Show resolved Hide resolved
@bharathi-tenneti
Copy link
Contributor Author

/retest

1 similar comment
@bharathi-tenneti
Copy link
Contributor Author

/retest

@bharathi-tenneti
Copy link
Contributor Author

/test pull-controller-runtime-test-master

@joelanford
Copy link
Member

This looks pretty good to me now based on our convo in the community meeting last time.

@DirectXMan12 Does this align with what you were thinking now?

@bharathi-tenneti
Copy link
Contributor Author

/assign @DirectXMan12

This was referenced Aug 14, 2020
Closed
Closed
@DirectXMan12
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020
@alvaroaleman
Copy link
Member

alvaroaleman commented Aug 18, 2020 •
edited

/hold cancel
based on Joes approval and Sollys lgtm (the /hold was originally added by Solly)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit b9af791 into kubernetes-sigs:master Aug 18, 2020
@STRRL STRRL mentioned this pull request Mar 3, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@estroz estroz estroz approved these changes

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@gerred gerred Awaiting requested review from gerred

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@DirectXMan12 DirectXMan12

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add log option and flag for zap time format
7 participants
@bharathi-tenneti @k8s-ci-robot @joelanford @DirectXMan12 @alvaroaleman @hasbro17 @estroz