Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetScale/UpdateScale methods to apps/v1 clients #70437

Merged
merged 2 commits into from Nov 1, 2018
Merged

Add GetScale/UpdateScale methods to apps/v1 clients #70437

merged 2 commits into from Nov 1, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 30, 2018 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds GetScale/UpdateScale methods for apps/v1 generated clients to prepare for switching usage to apps/v1

Special notes for your reviewer:
Extracted from #70370 for easier review

Builds on #70435

NONE

@kubernetes/sig-apps-pr-reviews

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Oct 30, 2018
@liggitt liggitt mentioned this pull request Oct 30, 2018
Merged
@liggitt
Copy link
Member Author

liggitt commented Oct 30, 2018

cc @kubernetes/sig-autoscaling-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Oct 30, 2018
@sttts
Copy link
Contributor

sttts commented Nov 1, 2018

/assign @s-urbaniak

@k8s-ci-robot
Copy link
Contributor

@sttts: GitHub didn't allow me to assign the following users: s-urbaniak.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @s-urbaniak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@s-urbaniak: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Nov 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit b04f83d into kubernetes:master Nov 1, 2018
@liggitt liggitt deleted the get-scale branch November 1, 2018 18:30
@liggitt liggitt mentioned this pull request Nov 1, 2018
Merged
@qiell qiell mentioned this pull request Mar 29, 2019
Merged
@spencerhance spencerhance mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @sttts @s-urbaniak