Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jest 26 #1595

Closed
ahnpnl opened this issue May 5, 2020 · 10 comments 路 Fixed by #1597
Closed

Support Jest 26 #1595

ahnpnl opened this issue May 5, 2020 · 10 comments 路 Fixed by #1597
Labels
馃殌 Feature Request new suggested feature

Comments

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 5, 2020

馃殌 Feature Proposal

Jest 26 has released. We need to provide support for that.

Motivation

Make developers feel comfortable to work

TODO

  • Set minimum required version of TypeScript to 3.8, example in chore (**BREAKING**): require minimum typescript@3.4聽#1530
  • Set jest version range for peerDependencies in root package.json.
  • Update e2e templates' dependencies.
  • Adjust codes to be compatible with Jest 26 in src/util/version-checker.ts and src/util/version-checker.spec.ts.
  • Change node 8 Travis to node 12 and change node 12 Travis to node 14.
  • Set prettier: 2.x, husky: 4.x, fs-extra: 9.x, semver: 7.x.
  • Upgrade some jest dependencies.
  • Set required minimum node@10 in package.json.
  • Update dependencies for projects in e2e/external-projects

If you see other things, please provide us information.

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 5, 2020

@kulshekhar should we separate 2 releases, with next branch target v25.5.0 and another branch target v26 ?

@murbanowicz murbanowicz mentioned this issue May 5, 2020
2 tasks
@ahnpnl ahnpnl linked a pull request May 5, 2020 that will close this issue
2 tasks
@kulshekhar
Copy link
Owner

@ahnpnl I'm not sure I understand the reason. Why would the next version be older that v26?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 5, 2020

actually my purpose is we separate 2 releases, as next branch will be merged into master first for release 25.5.0. After that this PR can land on next branch as for release 26.0.0.

I'm not sure if this approach is needed because there can be a situation that not all users can go immediately to jest 26 (which requires TypeScript 3.8). Currently 25.5.0-beta.0 (which is based on next branch) contains the most important change is performance boost for isolatedModules: false.

So IMO we should separate these 2 releases, as 25.5.0 goes first and 26.0.0 goes after that

@kulshekhar
Copy link
Owner

@ahnpnl that sounds good. I misunderstood earlier

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 5, 2020

Close via #1597

@ahnpnl ahnpnl closed this as completed May 5, 2020
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 6, 2020

this feature will be in the next release 26.0.0, ETA somewhere next week.

@GoldFlsh
Copy link

GoldFlsh commented May 13, 2020

Hello, just wondering if you still expect this this week?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 13, 2020

yes it is still on track :)

@GoldFlsh
Copy link

Yay!! :) thx for the update.

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 18, 2020

FYI 26.0.0 was out last weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃殌 Feature Request new suggested feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants