Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies jest + ts-jest to v26 #807

Merged
merged 2 commits into from
May 18, 2020

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented May 4, 2020

This PR contains the following updates:

Package Type Update Change
jest (source) devDependencies major ^25.0.0 -> ^26.0.0

Release Notes

facebook/jest

v26.0.1

Compare Source

Fixes
  • [jest-circus] Backward compatibility for deprecated DescribeBlock.tests to not break e.g. Detox reporter

v26.0.0

Compare Source

Features
  • [jest-environment-jsdom] [BREAKING] Upgrade jsdom to v16 (#​9606)
  • [@jest/fake-timers] Add possibility to use a modern implementation of fake timers, backed by @sinonjs/fake-timers (#​7776)
  • [jest-runtime] Add createMockFromModule as an alias for genMockFromModule (#​9962)
Fixes
  • [babel-jest] Handle null being passed to createTransformer (#​9955)
  • [jest-circus, jest-console, jest-jasmine2, jest-reporters, jest-util, pretty-format] Fix time durating formatting and consolidate time formatting code (#​9765)
  • [jest-circus] [BREAKING] Fail tests if a test takes a done callback and have return values (#​9129)
  • [jest-circus] [BREAKING] Throw a proper error if a test / hook is defined asynchronously (#​8096)
  • [jest-circus] Throw more descriptive error if hook is defined inside test (#​9957)
  • [jest-circus] [BREAKING] Align execution order of tests to match jasmine's top to bottom order (#​9965)
  • [jest-config, jest-resolve] [BREAKING] Remove support for browser field (#​9943)
  • [jest-haste-map] Stop reporting files as changed when they are only accessed (#​7347)
  • [jest-resolve] Show relative path from root dir for module not found errors (#​9963)
  • [jest-runtime] Fix absolute path moduleNameMapper + jest.mock bug (#​8727)
Chore & Maintenance
  • [*] [BREAKING] TypeScript definitions requires a minimum of TypeScript v3.8 (#​9823)
  • [*] [BREAKING] Drop support for Node 8 (#​9423)
  • [*] Upgrade to chalk@4 (#​9752)
  • [*] Remove usage of realpath-native (#​9952)
  • [docs] Fix example reference implementation to use Jest with Phabricator (#​8662)
  • [docs] Added default compiler to tranform (#​8583)
  • [docs] Updated Testing Frameworks guide with React; make it generic (#​9106)
  • [expect, jest-mock, pretty-format] [BREAKING] Remove build-es5 from package (#​9945)
  • [@jest/fake-timers, @​jest/environment] [BREAKING] Rename LolexFakeTimers to ModernFakeTimers (#​9960)
  • [jest-haste-map] [BREAKING] removed providesModuleNodeModules (#​8535)
  • [jest-runtime] [BREAKING] Remove long-deprecated require.requireActual and require.requireMock methods (#​9854)

Renovate configuration

📅 Schedule: "after 10pm every weekday,before 5am every weekday,every weekend" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 4, 2020 22:01
@andygout
Copy link
Contributor

andygout commented May 5, 2020

The CircleCI build has passed.

I have also run locally, which has produced this warning.

Screenshot 2020-05-05 at 08 16 38

I think that given we are not experiencing any ts-jest-related issues that we need not stick to a supported version of Jest (>=25.0.0 <26.0.0).

@@ -65,7 +65,7 @@
"eslint-plugin-import": "^2.16.0",
"eslint-plugin-jest": "^23.0.0",
"husky": "^4.0.0",
"jest": "^25.0.0",
"jest": "^26.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest and ts-jest will need to maintain version parity, so we should bump that package too.

Copy link
Contributor

@andygout andygout May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case we will have to wait as the latest version of ts-jest is v25.4.0: https://www.npmjs.com/package/ts-jest.

Options seem to be:

  • Close this PR and create our own to bump both jest and ts-jest to v26 once the latter releases its version of that.
  • Keep this PR open (which might go stale) and wait until ts-jest releases v26 and update this existing PR.
  • Merge this PR on the basis that we are currently encountering no issues (although may well do if changes are added that expose the incompatibility of the two versions) and update ts-jest v26 when it arrives.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kulshekhar/ts-jest#1595 kulshekhar/ts-jest: Support Jest 26 (ts-jest issue opened 37 minutes ago).

There is quite a lot of recent activity on the ts-jest repo which suggests it will not be too long before v26 is released.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ts-jest maintainers are usually very responsive 😄 We could add DO NOT MERGE label for now and check in on it again at the end of the day?

@renovate
Copy link
Author

renovate bot commented May 18, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@andygout
Copy link
Contributor

Updating the ts-jest dependency gets rid of those warnings.

Screenshot 2020-05-18 at 09 21 33

@andygout andygout mentioned this pull request May 18, 2020
1 task
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, fingers crossed this'll work once you rebase this branch against master.

@andygout andygout force-pushed the renovate/major-jest-monorepo branch from 830aae1 to 4585d59 Compare May 18, 2020 08:59
@andygout andygout changed the title Update dependency jest to v26 Update dependencies jest + ts-jest to v26 May 18, 2020
@andygout andygout merged commit 2639afc into master May 18, 2020
@andygout andygout deleted the renovate/major-jest-monorepo branch May 18, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants