Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http2. #494

Closed
wants to merge 3 commits into from
Closed

Support http2. #494

wants to merge 3 commits into from

Conversation

sogaani
Copy link

@sogaani sogaani commented Aug 2, 2018

Hi

This PR adds http2 support to add http2 tests on express.
This PR depend on ladjs/superagent#1399.

@DullReferenceException
Copy link

Any updates on this? I'm looking to upgrade some existing tests that use supertest so they use http2.

@alexander-akait
Copy link

/cc @rimiti friendly ping, what is blocker to support this? We need this for express and webpack-dev-server

@gabrielcsapo
Copy link

any update on this?

Copy link
Contributor

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To update the dependencies to not point to git/forked repositories.

},
"dependencies": {
"methods": "~1.1.2",
"superagent": "3.8.2"
"superagent": "git+https://github.com/visionmedia/superagent.git"
Copy link
Contributor

@lamweili lamweili Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"superagent": "git+https://github.com/visionmedia/superagent.git"
"superagent": "^8.0.0"

Maybe point back to superagent@^8.0.0 now that ladjs/superagent#1414 has been merged.

PS: superagent@^8.0.0 is in the master branch package.json at the time of writing.

},
"devDependencies": {
"body-parser": "^1.18.2",
"cookie-parser": "^1.4.3",
"eslint": "^4.19.1",
"eslint-config-airbnb-base": "^12.1.0",
"eslint-plugin-import": "2.11.0",
"express": "^4.16.3",
"express": "git+https://github.com/sogaani/express.git#initial-support-http2",
Copy link
Contributor

@lamweili lamweili Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"express": "git+https://github.com/sogaani/express.git#initial-support-http2",
"express": "^4.18.1",

Similar to ladjs/superagent#1414 (comment), it would be good to depend directly on express@^4.18.1.

PS: express@^4.18.1 is in the master branch package.json at the time of writing.

@lamweili
Copy link
Contributor

This PR looks promising but would need @sogaani to resolve the conflicts or rebase.

@lamweili lamweili mentioned this pull request Oct 3, 2022
@lamweili
Copy link
Contributor

lamweili commented Oct 4, 2022

This PR looks promising but would need @sogaani to resolve the conflicts or rebase.

@rimiti, I have taken the liberty to create a new PR #793 which is based on @sogaani's work.

@titanism
Copy link
Collaborator

titanism commented Oct 4, 2022

Closed via #793 and released in v6.3.0

@titanism titanism closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants