Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade npm to v9 #164

Merged
merged 1 commit into from Dec 19, 2022
Merged

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

This PR:

Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror
Copy link
Member Author

Odd that all checks ran just fine here?

Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking over the npm 9 changelog, I don't see anything that would affect us here when upgrading from v8. The main changes were the node ranges it supports (19 is in the upper end of that range), and how it handles and reports error conditions (all of which will only help us).

🚢

@weierophinney weierophinney merged commit 6a84a59 into laminas:1.22.x Dec 19, 2022
@internalsystemerror internalsystemerror deleted the upgrade-npm-9 branch December 19, 2022 15:22
@internalsystemerror internalsystemerror added this to the 1.22.0 milestone Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants