MethodGenerator::fromArray() add config keys #119
Closed
+49
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add keys `'returntype'/setReturnType()` and `'returnsreference'/setReturnsReference()`. Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Added dataProvider to cover cast behavior Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Brammm
commented
Dec 6, 2021
| } | ||
|
|
||
| /** | ||
| * @return string[][] |
There was a problem hiding this comment.
Just realized this type is wrong (copied from somewhere else and then forgotten about), though not sure about conventions in the project as to what I should change it to.
Ocramius
approved these changes
Dec 7, 2021
| @@ -310,6 +314,11 @@ public function setReturnsReference($returnsReference) | |||
| return $this; | |||
| } | |||
|
|
|||
| public function isReturnsReference(): bool | |||
There was a problem hiding this comment.
The is should really be removed here - naming is totally wonky (will rename on merge)
| } | ||
|
|
||
| /** | ||
| * @return string[][] |
Ocramius
added a commit
that referenced
this pull request
Dec 7, 2021
…rence-on-methods-generated-via-arrays Allow setting by-reference return on methods generated via `MethodGenerator::fromArray()`, add `MethodGenerator#returnsReference()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #107