Allow setting by-reference return on methods generated via MethodGenerator::fromArray(), add MethodGenerator#returnsReference()
#121
+51
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add keys `'returntype'/setReturnType()` and `'returnsreference'/setReturnsReference()`. Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Added dataProvider to cover cast behavior Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
Signed-off-by: Bram Van der Sype <bram.vandersype@gmail.com>
…nario wording and type declarations Signed-off-by: Marco Pivetta <ocramius@gmail.com>
Ocramius
changed the title
MethodGenerator::fromArray(), add MethodGenerator#returnsReference()
Ocramius
deleted the
feature/#119-allow-setting-reference-on-methods-generated-via-arrays
branch
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
Fixes #107
Description
This adds the ability to specify a
returnsreferenceinput value forMethodGenerator::fromArray(), and makes this value accessible viaMethodGenerator#returnsReference().The patch is a rebased/squashed version of #107 and then #119
Thanks @brian978 @WinterSilence!