Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Attribute Cast Performance Improvements #43554

Merged
merged 3 commits into from Aug 5, 2022
Merged

[9.x] Attribute Cast Performance Improvements #43554

merged 3 commits into from Aug 5, 2022

Commits on Aug 4, 2022

  1. Remove repeated calls to getCasts() in same method

    @serpentblade
    serpentblade committed Aug 4, 2022
    Copy the full SHA
    d71dfdf View commit details
    Browse the repository at this point in the history

  2. Switch strncmp to starts_with_str 

    Marginally faster, better readability, and matches similar functions
    @serpentblade
    serpentblade committed Aug 4, 2022
    Copy the full SHA
    c156e13 View commit details
    Browse the repository at this point in the history

  3. Add castTypeCache 

    getCastType is called a lot when processing models with defined casts and contributes to a significant number of overall calls.  Caching the results of the key conversion can result in significant performance improvement when processing large numbers of models.
    @serpentblade
    serpentblade committed Aug 4, 2022
    Copy the full SHA
    424e8cf View commit details
    Browse the repository at this point in the history