Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Attribute Cast Performance Improvements #43554

Merged
merged 3 commits into from Aug 5, 2022
Merged

[9.x] Attribute Cast Performance Improvements #43554

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d71dfdf
Remove repeated calls to getCasts() in same method
serpentblade Aug 4, 2022
c156e13
Switch strncmp to starts_with_str
serpentblade Aug 4, 2022
424e8cf
Add castTypeCache
serpentblade Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 29 additions & 14 deletions src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
View file
Open in desktop
Expand Up @@ -165,6 +165,13 @@ trait HasAttributes
*/
protected static $setAttributeMutatorCache = [];

/**
* The cache of the converted cast types.
*
* @var array
*/
protected static $castTypeCache = [];

/**
* The encrypter instance that is used to encrypt attributes.
*
Expand Down Expand Up @@ -818,19 +825,23 @@ protected function getEnumCastableAttributeValue($key, $value)
*/
protected function getCastType($key)
{
if ($this->isCustomDateTimeCast($this->getCasts()[$key])) {
return 'custom_datetime';
}
$castType = $this->getCasts()[$key];

if ($this->isImmutableCustomDateTimeCast($this->getCasts()[$key])) {
return 'immutable_custom_datetime';
if (isset(static::$castTypeCache[$castType])) {
return static::$castTypeCache[$castType];
}

if ($this->isDecimalCast($this->getCasts()[$key])) {
return 'decimal';
if ($this->isCustomDateTimeCast($castType)) {
$convertedCastType = 'custom_datetime';
} elseif ($this->isImmutableCustomDateTimeCast($castType)) {
$convertedCastType = 'immutable_custom_datetime';
} elseif ($this->isDecimalCast($castType)) {
$convertedCastType = 'decimal';
} else {
$convertedCastType = trim(strtolower($castType));
}

return trim(strtolower($this->getCasts()[$key]));
return static::$castTypeCache[$castType] = $convertedCastType;
}

/**
Expand Down Expand Up @@ -882,8 +893,8 @@ protected function isCustomDateTimeCast($cast)
*/
protected function isImmutableCustomDateTimeCast($cast)
{
return strncmp($cast, 'immutable_date:', 15) === 0 ||
strncmp($cast, 'immutable_datetime:', 19) === 0;
return str_starts_with($cast, 'immutable_date:') ||
str_starts_with($cast, 'immutable_datetime:');
}

/**
Expand Down Expand Up @@ -1491,11 +1502,13 @@ protected function isEncryptedCastable($key)
*/
protected function isClassCastable($key)
{
if (! array_key_exists($key, $this->getCasts())) {
$casts = $this->getCasts();

if (! array_key_exists($key, $casts)) {
return false;
}

$castType = $this->parseCasterClass($this->getCasts()[$key]);
$castType = $this->parseCasterClass($casts[$key]);

if (in_array($castType, static::$primitiveCastTypes)) {
return false;
Expand All @@ -1516,11 +1529,13 @@ protected function isClassCastable($key)
*/
protected function isEnumCastable($key)
{
if (! array_key_exists($key, $this->getCasts())) {
$casts = $this->getCasts();

if (! array_key_exists($key, $casts)) {
return false;
}

$castType = $this->getCasts()[$key];
$castType = $casts[$key];

if (in_array($castType, static::$primitiveCastTypes)) {
return false;
Expand Down