Ban circular dependencies #2822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
force-pushed
the
ban-circular-dependencies
branch
from
76048e5
to
33422ce
Compare
Nokel81
force-pushed
the
cleanup-ipc-registration
branch
from
492fa6f
to
fab0137
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Prevents some circular dependencies - Allowed main to use them as needed Signed-off-by: Sebastian Malton <sebastian@malton.name>
- Helps moves towards turning on banning CyclicImports Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
cleanup-ipc-registration
branch
from
fab0137
to
d5bfa3a
Compare
- ApiManager now creates the instances of all stores - ReleaseStore is Singleton-like - Move most types and helper functions into seperate files Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
ban-circular-dependencies
branch
from
b9c4ea3
to
f25dc4a
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Making this a draft since it requires some other PRs and I think I should focus on other things. |
Nokel81
force-pushed
the
cleanup-ipc-registration
branch
from
d5bfa3a
to
b3b83fa
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
cleanup-ipc-registration
branch
2 times, most recently
from
574fae0
to
a09ac6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApiManager now creates the instances of all stores
ReleaseStore is Singleton-like
Move most types and helper functions into seperate files
Signed-off-by: Sebastian Malton sebastian@malton.name
Note: this currently uses webpack's
CircularDependencyPluginbut once import-js/eslint-plugin-import#2083 has made its way into a release we should move to that as then we can get in-editor errors.