Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban circular dependencies #2822

Closed
wants to merge 5 commits into from
Closed

Ban circular dependencies #2822

wants to merge 5 commits into from

Commits on May 20, 2021

  1. Move all RouteParam's and URL builders to src/common 

    - Prevents some circular dependencies

- Allowed main to use them as needed

Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed May 20, 2021
    Configuration menu
    Copy the full SHA
    e8babbb View commit details
    Browse the repository at this point in the history

  2. Explicitly initialize registries 

    - Helps moves towards turning on banning CyclicImports

Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed May 20, 2021
    Configuration menu
    Copy the full SHA
    034fc4a View commit details
    Browse the repository at this point in the history

  3. Add more specific IPC helpers 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed May 20, 2021
    Configuration menu
    Copy the full SHA
    d5bfa3a View commit details
    Browse the repository at this point in the history

  4. Ban circular dependencies 

    - ApiManager now creates the instances of all stores

- ReleaseStore is Singleton-like

- Move most types and helper functions into seperate files

Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed May 20, 2021
    Configuration menu
    Copy the full SHA
    e0a9fff View commit details
    Browse the repository at this point in the history

  5. fix some tests 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed May 20, 2021
    Configuration menu
    Copy the full SHA
    f25dc4a View commit details
    Browse the repository at this point in the history