Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support changelog-presets using async factory funcs #3873

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: support changelog-presets using async factory funcs #3873

merged 1 commit into from
Oct 24, 2023

Conversation

amorscher
Copy link
Contributor

new 7.x.x versions of conventional changelog presets use async factory functions createPreset (see conventional-changelog/conventional-changelog#1045)

Description

Fixes #3871

Motivation and Context

#3871

How Has This Been Tested?

unit and e2e tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [x I have added tests to cover my changes.
  • All new and existing tests passed.

@amorscher
fix: support changelog-presets using async factory funcs
3e6c873 
 - new 7.x.x versions of conventional changelog presets use async
   factory functions createPreset (see conventional-changelog/conventional-changelog#1045)
@fahslaj
Copy link
Contributor

fahslaj commented Oct 24, 2023

Thank you @amorscher !

@fahslaj fahslaj merged commit bb5e7d7 into lerna:main Oct 24, 2023
13 checks passed
@fahslaj fahslaj mentioned this pull request Oct 24, 2023
Closed
amorscher added a commit to amorscher/lerna that referenced this pull request Oct 27, 2023
@amorscher
fix(version): support changelog-presets using async factory funcs (le…
40be032 
…rna#3873)
@ghiscoding ghiscoding mentioned this pull request Nov 12, 2023
Closed
5 tasks
@ghiscoding ghiscoding mentioned this pull request Nov 19, 2023
Merged
9 tasks
@jcfranco jcfranco mentioned this pull request Jan 24, 2024
Merged
1 task
@Atomic2048 Atomic2048 mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahslaj fahslaj fahslaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using conventionalcommits as changelogPreset causes lerna version to do nothing
2 participants
@amorscher @fahslaj