build: build with -D_FILE_OFFSET_BITS=64 again #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Mar 20, 2018
santigimeno
approved these changes
Mar 20, 2018
|
I thought about it but creating big files, even temporary ones, arguably isn't nice. I'm also not 100% sure if it would work on all CI machines; some are pretty space-constrained at times. |
|
https://ci.nodejs.org/job/libuv-test-commit/762/ - it's like I feared, some of the buildbots don't handle big files well. |
|
Yeah, I'm having similar issues with #1553. I have had to increase the timeout to 120 secs to make the tests pass regularly, though I don't know if it's worthy. |
addaleax
approved these changes
Mar 20, 2018
Faulty logic in commit fdf7c2a ("build: split off tests into separate gyp file") accidentally disabled `-D_FILE_OFFSET_BITS=64` on Unices, breaking file operations on files > 2 GB on 32 bits platforms. Fixes: nodejs/node#19455 PR-URL: libuv#1779 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Sorry @addaleax, hadn't seen your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faulty logic in commit fdf7c2a ("build: split off tests into separate
gyp file") accidentally disabled
-D_FILE_OFFSET_BITS=64on Unices,breaking file operations on files > 2 GB on 32 bits platforms.
Fixes: nodejs/node#19455
CI: https://ci.nodejs.org/job/libuv-test-commit/760/