Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: build with -D_FILE_OFFSET_BITS=64 again #1779

Merged
merged 1 commit into from
Mar 21, 2018
Merged

build: build with -D_FILE_OFFSET_BITS=64 again #1779

merged 1 commit into from
Mar 21, 2018

Commits on Mar 21, 2018

  1. build: build with -D_FILE_OFFSET_BITS=64 again 

    Faulty logic in commit fdf7c2a ("build: split off tests into separate
gyp file") accidentally disabled `-D_FILE_OFFSET_BITS=64` on Unices,
breaking file operations on files > 2 GB on 32 bits platforms.

Fixes: nodejs/node#19455
PR-URL: libuv#1779
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    ee875f9 View commit details
    Browse the repository at this point in the history