Change the boundary inclusivity of exponential histogram #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
changed the title
ocelotl
approved these changes
Aug 26, 2022
|
To be clear, the only differences between this PR and the pending work in open-telemetry/opentelemetry-go#3022 are the import paths. |
|
Bypassing the build errors because these are tooling issues. This repo does not build with go-1.19 and the CI tools do not run with 1.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Applies pending changes from the future release of otel-go 1.10. Particularly, the boundary-inclusivity change open-telemetry/opentelemetry-go#2982 is incorporated along with the pending work in open-telemetry/opentelemetry-go#3022.
Link to tracking Issue: #253
Testing: Note that the tests change a lot because of the boundary inclusivity change. See the discussion in open-telemetry/opentelemetry-go#3022.