Remove spring.config.use-legacy-processing in tests
#4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When we upgrade to Spring Boot 2.4, we used `spring.config.use-legacy-processing` property because main application.yml overrides the yaml files in test. However, it was a bug and fixed. spring-projects/spring-boot#24719 Therefore, we don't have to use `spring.config.use-legacy-processing` anymore. Modifications: - Remove `spring.config.use-legacy-processing` property Result: - Close line#4899
minwoox
commented
May 26, 2023
| @@ -6,4 +6,4 @@ spring.config.activate.on-profile: local | |||
| armeria: | |||
| ports: | |||
| - port: 8080 | |||
| protocol: HTTP | |||
| protocols: HTTP | |||
There was a problem hiding this comment.
This field is a list and we can just specify the element without enclosing brackets. e.g. [HTTP]
It's because Spring has relaxed rule for the list value.
However, this doesn't apply to Dropwizard so we cannot use the same rule.
jrhee17
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When we upgrade to Spring Boot 2.4, we used
spring.config.use-legacy-processingproperty because main application.yml overrides the yaml files in the test. However, it was a bug and was fixed.spring-projects/spring-boot#24719 Therefore, we don't have to use
spring.config.use-legacy-processinganymore.Modifications:
spring.config.use-legacy-processingpropertyResult:
spring.config.use-legacy-processingin our test application file #4899