Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring.config.use-legacy-processing in tests #4900

Merged
merged 1 commit into from Jun 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

# Disable the Web Server.
# See https://docs.spring.io/spring-boot/docs/current/reference/html/howto-embedded-web-servers.html.
spring.main.web-application-type: none
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

# Disable the Web Server.
# See https://docs.spring.io/spring-boot/docs/current/reference/html/howto-embedded-web-servers.html.
spring.main.web-application-type: none
Expand Down
Expand Up @@ -6,4 +6,4 @@ spring.config.activate.on-profile: local
armeria:
ports:
- port: 8080
protocol: HTTP
protocols: HTTP
Copy link
Member Author

@minwoox minwoox May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is a list and we can just specify the element without enclosing brackets. e.g. [HTTP]
It's because Spring has relaxed rule for the list value.
However, this doesn't apply to Dropwizard so we cannot use the same rule.

@@ -1,12 +1,7 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

# Prevent the embedded Tomcat from opening a TCP/IP port.
server.port: -1
---
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
Expand Up @@ -12,4 +12,4 @@ armeria:
- http
- proxy
- port: 8080 # Port 8080 will serve only HTTP.
protocol: http
protocols: http
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

# Use a random port to avoid a potential port conflict.
server:
port: 0
Expand Down
@@ -1,4 +1,4 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
@@ -1,4 +1,4 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
@@ -1,7 +1,7 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
server:
error:
include-message: always
@@ -1,7 +1,7 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP

management:
server:
Expand Down
1 change: 0 additions & 1 deletion site/src/pages/docs/advanced-dropwizard-integration.mdx
Expand Up @@ -118,7 +118,6 @@ server:
protocols:
- HTTPS
- PROXY
ports:
compression:
enabled: true
mimeTypes:
Expand Down
6 changes: 3 additions & 3 deletions site/src/pages/release-notes/0.83.0.mdx
Expand Up @@ -11,12 +11,12 @@ date: 2019-03-29
armeria:
ports:
- port: 8080
protocol: HTTP
protocols: HTTP
- ip: 127.0.0.1
port: 8081
protocol:HTTP
protocols: HTTP
- port: 8443
protocol: HTTPS
protocols: HTTPS
ssl:
key-alias: "host.name.com"
key-store: "keystore.jks"
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/release-notes/0.84.0.mdx
Expand Up @@ -123,7 +123,7 @@ date: 2019-04-23
armeria:
ports:
- port: 8080
protocol: HTTP
protocols: HTTP
compression:
enabled: true
mime-types: text/*, application/json
Expand Down
Expand Up @@ -2,7 +2,7 @@ armeria:
ports:
- ip: 127.0.0.1
port: 0
protocol: HTTP
protocols: HTTP
- ip: 0.0.0.0
port: 0
protocol: HTTP
protocols: HTTP
Expand Up @@ -2,4 +2,4 @@ armeria:
ports:
- address: localhost
port: 0
protocol: HTTP
protocols: HTTP
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,13 +1,13 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
- address: 127.0.0.1
port: 0
protocol: HTTP
protocols: HTTP
- address: 0.0.0.0
port: 0
protocol: HTTP
protocols: HTTP

management:
endpoints:
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,13 +1,13 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
- address: 127.0.0.1
port: 0
protocol: HTTP
protocols: HTTP
- address: 0.0.0.0
port: 0
protocol: HTTP
protocols: HTTP
metrics-path: ''

management:
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

armeria:
ports:
- port: 0
Expand Down
Expand Up @@ -49,12 +49,12 @@
* armeria:
* ports:
* - port: 8080
* protocol: HTTP
* protocols: HTTP
* - address: 127.0.0.1
* port: 8081
* protocol:HTTP
* protocols: HTTP
* - port: 8443
* protocol: HTTPS
* protocols: HTTPS
* ssl:
* key-alias: "host.name.com"
* key-store: "keystore.jks"
Expand Down
Expand Up @@ -12,11 +12,11 @@ management:
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
- address: 127.0.0.1
port: 0
protocol: HTTP
protocols: HTTP
- address: 0.0.0.0
port: 0
protocol: HTTP
protocols: HTTP
enable-auto-injection: true
@@ -1,7 +1,7 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
compression:
enabled: true
mime-types: text/*, application/json
Expand Down
@@ -1,8 +1,3 @@
# Use-legacy-processing to use this application-testbed.yml file instead of application.yml
spring:
config:
use-legacy-processing: true

# Should not bind internal services to the management.server.port
# if ArmeriaSpringActuatorAutoConfiguration was not configured.
management.server.port: 0
Expand Down
@@ -1,9 +1,9 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP
- port: 0
protocol: HTTPS
protocols: HTTPS
ssl:
enabled: true # Use self-signed certificate because no key-store configuration is specified.
# Make sure that port-based virtual host settings are compatible with Server Name Indication.
Expand Down
@@ -1,7 +1,7 @@
armeria:
ports:
- port: 0
protocol: HTTP
protocols: HTTP

management:
endpoints:
Expand Down