fix: resolve matched files to cwd instead of gitDir before adding

[iiroj]

Because the set of matched files are collected from generated tasks, when using the relative options they are relative to the current cwd, not the git dir which might be different.

[iiroj]

Need to normalize the asserted path in tests for the Windows test.

[iiroj]

@okonet I split into two commits because there was technically another fix in there.

EDIT: argh, one more test, one more missing normalize.

[iiroj]

@okonet it seems the Appveyor test is failing to something not-test-related. Can you re-trigger it manually somehow?

[okonet]

I just did but it's still failing with the same message:

error Command failed with exit code 3221225477.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Command exited with code -1073741819

There is no information behind this link... Ideas? Can it be Node 14?

[okonet]

Okay I restarted the whole build and now it seem to work: https://ci.appveyor.com/project/okonet/lint-staged

[okonet]

@iiroj let me know if that's good to merge and I'll merge it since the check wasn't picked up here but it's all green now.

[iiroj]

@okonet thanks, please do! A merge commit would be better to preserve both fixes in the changelog.

[github-actions]

🎉 This PR is included in version 10.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[ram3shyadav]

@okonet @iiroj

still not fixed
for git, file location is Development/WebApps/Digital/DigitalPlatform/ClientApp/src/app/api/interceptors/api.interceptor.ts

but git is trying to add Digital/DigitalPlatform/ClientApp/src/app/api/interceptors/api.interceptor.ts which is relative to package.json or cwd

  lint-staged:git Running git command [ 'diff', '--staged', '--diff-filter=ACMR', '--name-only', '-z' ] +11ms
  lint-staged:run Loaded list of staged files in git:
  lint-staged:run [ 'Development/WebApps/Digital/DigitalPlatform/ClientApp/src/app/api/interceptors/api.interceptor.ts' ] +39ms
  lint-staged:chunkFiles Resolved an argument string length of 97 characters from 1 files +0ms
  lint-staged:chunkFiles Creating 1 chunks for maxArgLength of 131072 +1ms
  lint-staged:gen-tasks Generating linter tasks +0ms
  lint-staged:gen-tasks Generated task: 
  lint-staged:gen-tasks { pattern: '*.{ts,js,html,css,scss,json}',
  lint-staged:gen-tasks   commands: [ 'prettier --write' ],
  lint-staged:gen-tasks   fileList:
  lint-staged:gen-tasks    [ 'Digital/DigitalPlatform/ClientApp/src/app/api/interceptors/api.interceptor.ts' ] } +9ms
  lint-staged:gen-tasks Generated task: 
  lint-staged:gen-tasks { pattern: '*.ts',
  lint-staged:gen-tasks   commands: [ 'tslint --fix' ],
  lint-staged:gen-tasks   fileList:
  lint-staged:gen-tasks    [ 'Digital/DigitalPlatform/ClientApp/src/app/api/interceptors/api.interceptor.ts' ] } +1ms

  lint-staged:git Adding task modifications to index... +774ms
  lint-staged:git Running git command [ 'add',
  '--',
  'Digital/DigitalPlatform/ClientApp/src/app/api/interceptors/api.interceptor.ts' ] +839ms
✖ fatal: pathspec 'Digital/DigitalPlatform/ClientApp/src/app/api/interceptors/api.interceptor.ts' did not match any files```

[iiroj]

What, I set it to resolve to absolute paths... 🤔 Let me see again.

EDIT: LOL, found the issue. This PR fixed it for the case where maxArgLenth is not defined, but left it unfixed for all else.

[iiroj]

@Ramesh-Yadav I opened #858 to hopefully fix it for good!