Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAT-8906] Added validation errors for SQLite and DB2z databases #2359

Merged
merged 1 commit into from Jan 19, 2022
Merged

[DAT-8906] Added validation errors for SQLite and DB2z databases #2359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions liquibase-core/src/main/java/liquibase/sqlgenerator/core/AddAutoIncrementGenerator.java
View file
Open in desktop
Expand Up @@ -22,6 +22,7 @@ public int getPriority() {
@Override
public boolean supports(AddAutoIncrementStatement statement, Database database) {
return (database.supportsAutoIncrement()
&& !(database instanceof Db2zDatabase)
&& !(database instanceof DerbyDatabase)
&& !(database instanceof MSSQLDatabase)
&& !(database instanceof HsqlDatabase)
Expand Down
8 changes: 6 additions & 2 deletions liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateProcedureGenerator.java
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@
import liquibase.Scope;
import liquibase.database.Database;
import liquibase.database.core.*;
import liquibase.exception.DatabaseException;
import liquibase.exception.ValidationErrors;
import liquibase.executor.Executor;
import liquibase.executor.ExecutorService;
Expand All @@ -20,11 +19,16 @@
import liquibase.util.SqlParser;
import liquibase.util.StringClauses;
import liquibase.util.StringUtil;

import java.util.ArrayList;
import java.util.List;

public class CreateProcedureGenerator extends AbstractSqlGenerator<CreateProcedureStatement> {

@Override
public boolean supports(CreateProcedureStatement statement, Database database) {
return !(database instanceof SQLiteDatabase);
}

@Override
public ValidationErrors validate(CreateProcedureStatement statement, Database database, SqlGeneratorChain sqlGeneratorChain) {
ValidationErrors validationErrors = new ValidationErrors();
Expand Down
7 changes: 7 additions & 0 deletions liquibase-core/src/main/java/liquibase/sqlgenerator/core/DropProcedureGenerator.java
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@

import liquibase.database.Database;
import liquibase.database.core.MSSQLDatabase;
import liquibase.database.core.SQLiteDatabase;
import liquibase.exception.ValidationErrors;
import liquibase.sql.Sql;
import liquibase.sql.UnparsedSql;
Expand All @@ -11,6 +12,12 @@
import liquibase.structure.core.StoredProcedure;

public class DropProcedureGenerator extends AbstractSqlGenerator<DropProcedureStatement> {

@Override
public boolean supports(DropProcedureStatement statement, Database database) {
return !(database instanceof SQLiteDatabase);
}

@Override
public ValidationErrors validate(DropProcedureStatement statement, Database database, SqlGeneratorChain sqlGeneratorChain) {
ValidationErrors validationErrors = new ValidationErrors();
Expand Down
2 changes: 1 addition & 1 deletion liquibase-core/src/main/java/liquibase/sqlgenerator/core/ModifyDataTypeGenerator.java
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ public class ModifyDataTypeGenerator extends AbstractSqlGenerator<ModifyDataType

@Override
public boolean supports(ModifyDataTypeStatement statement, Database database) {
if (database instanceof SQLiteDatabase) {
if (database instanceof SQLiteDatabase || database instanceof Db2zDatabase) {
return false;
}
return super.supports(statement, database);
Expand Down
3 changes: 2 additions & 1 deletion liquibase-core/src/main/java/liquibase/sqlgenerator/core/RenameSequenceGenerator.java
View file
Open in desktop
Expand Up @@ -19,7 +19,8 @@ public boolean supports(RenameSequenceStatement statement, Database database) {
&& !(database instanceof FirebirdDatabase)
&& !(database instanceof H2Database)
&& !(database instanceof HsqlDatabase)
&& !(database instanceof InformixDatabase);
&& !(database instanceof InformixDatabase)
&& !(database instanceof SQLiteDatabase);
}

@Override
Expand Down