Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAT-17502] added FK support #5905

Merged
merged 4 commits into from
May 22, 2024
Merged

[DAT-17502] added FK support #5905

merged 4 commits into from
May 22, 2024

Conversation

KushnirykOleh
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added classes to support FK for BigQuery. BigQueryDropForeignKeyConstraintGenerator is not needed as default implementation works fine

@KushnirykOleh KushnirykOleh mentioned this pull request May 13, 2024
Open
filipelautert
filipelautert requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is fine. I'm just asking for PreparedStatements were possible as we are trying to improve this on core.

...ibase-bigquery/src/main/java/liquibase/snapshot/jvm/BigQueryForeignKeySnapshotGenerator.java Outdated Show resolved Hide resolved
...ibase-bigquery/src/main/java/liquibase/snapshot/jvm/BigQueryForeignKeySnapshotGenerator.java Outdated Show resolved Hide resolved
@PavloTytarchuk PavloTytarchuk merged commit 04030d6 into DAT-17482 May 22, 2024
30 of 32 checks passed
@PavloTytarchuk PavloTytarchuk deleted the DAT-17502 branch May 22, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliimak vitaliimak vitaliimak approved these changes

@filipelautert filipelautert filipelautert approved these changes

Assignees
No one assigned
Labels
TypeEnhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KushnirykOleh @vitaliimak @filipelautert @PavloTytarchuk