Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts issue with moduleResolution: NodeNext #3252

Closed
wants to merge 2 commits into from
Closed

fix: ts issue with moduleResolution: NodeNext #3252

wants to merge 2 commits into from

Conversation

Mister-Hope
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

⚠️ No Changeset found

Latest commit: 91f881b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla
Copy link

google-cla bot commented Aug 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@justinfagnani
Copy link
Collaborator

Thanks! Looks good, but we need a changeset file. Run npm run changeset, choose the lit package, and write a description of the chage.

Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset

@augustjk
Copy link
Member

Thanks for original contribution. This PR is no longer needed with #3320 merged, as we needed the types to point to those in the development directory instead of the package root.

@augustjk augustjk closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants