Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[labs/ssr-dom-shim] Add basic support for element internals #3677
[labs/ssr-dom-shim] Add basic support for element internals #3677
Changes from 15 commits
cba3c95
49b7387
fbaa901
3684584
94a1b81
c1d6b27
2d9d094
f138ee6
e8f93cf
eeb1513
f3b1779
bfec6b4
d581707
88038e5
dcef2b4
056a39c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this only work when we're using our shim. We need to think about what happens if someone loads jsdom. We may need adapters, like a
getInternals()
callback.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there's anything to be done right now. Neither
jsdom
norhappy-dom
haveattachInternals()
implemented and a canonical way of getting the internals object from an element doesn't exist.Do you mean a
getInternals()
on the element renderer? This would be more of a DOM shim dependent thing rather than an element renderer thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have an issue somewhere for using another DOM shim, and this can go on the list of things we'll need to consider there. What I mean by
getInternals()
is that since there's no standard DOM API for getting at that from outside a component, we'll need a callback per DOM emulation library to get at it. Future work, just noting it.