Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow unknown commit types #46

Merged
merged 1 commit into from Jun 25, 2019
Merged

feat: Allow unknown commit types #46

merged 1 commit into from Jun 25, 2019

Conversation

ffflorian
Copy link
Contributor

@ffflorian ffflorian commented Nov 6, 2018

This PR will

  • add a flag to allow unknown commit types.

Reason

Sometimes you want to use other commit types in your repository (e.g. run-fix to mark fixes concerning only the current feature run). These should not all be grouped into "Other changes" then.

Result

Commits with unknown types will then be each grouped into Other changes (<commit type>).

Example

New Features
  • docs: Add docs (fd616edf)
Other Changes (run-fix)
  • docs: Fixed typo (658297e9)

lib/git.js Show resolved Hide resolved
test/writer.test.js Outdated Show resolved Hide resolved
@ffflorian
Copy link
Contributor Author

@robinjoseph08 any update on this?

@bennycode
Copy link
Contributor

@dmlittle & @robinjoseph08 Can you help us getting this change in? We are a bit puzzled on how to write a test here.

@ffflorian
Copy link
Contributor Author

I updated the test.

@bennycode
Copy link
Contributor

@dmlittle & @robinjoseph08 Do you have time to review this PR?

@ffflorian
Copy link
Contributor Author

@dmlittle @robinjoseph08 Would be great if we could get this feature into generate-changelog. 🙂

Copy link
Contributor

@robinjoseph08 robinjoseph08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terribly sorry for the delay here. LGTM! We'll get a new version cut shortly. Thank you for your contribution!

@robinjoseph08 robinjoseph08 merged commit b2fb9ff into lob:master Jun 25, 2019
@robinjoseph08
Copy link
Contributor

Just released v1.8.0! Again, really sorry for the delay!

@ffflorian ffflorian deleted the feat/allow-unknown branch June 25, 2019 20:15
@ScottBrenner
Copy link
Contributor

ScottBrenner commented Mar 5, 2020

Hi, have a quick fix for two typos introduced here - #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants