Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store.openKeyCursor fallback to store.openCursor #971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

banjerluke
Copy link

Simple fix to support legacy browsers like Edge 18. Fixes #970.

Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks so much!

It's a bit late here so I'll get this merged and deployed sometime tomorrow (Saturday) 🙂

@zspitzer
Copy link

is there any chance of this getting merged in?

@leeacker
Copy link

also wondering when this might be available - thanks!

ronnix added a commit to Delegation-numerique-en-sante/mesconseilscovid that referenced this pull request Aug 24, 2020
Le problème a été introduit dans la 1.7.4 : localForage/localForage#970

Un correctif est en attente d’intégration : localForage/localForage#971
ronnix added a commit to Delegation-numerique-en-sante/mesconseilscovid that referenced this pull request Aug 24, 2020
Le problème a été introduit dans la 1.7.4 : localForage/localForage#970

Un correctif est en attente d’intégration : localForage/localForage#971
ronnix added a commit to Delegation-numerique-en-sante/mesconseilscovid that referenced this pull request Aug 24, 2020
Le problème a été introduit dans la 1.7.4 : localForage/localForage#970

Un correctif est en attente d’intégration : localForage/localForage#971
@hmhealey
Copy link

We're also interested in having this in as well. We're having to temporarily patch this for now.

@zspitzer
Copy link

This problem is made worse coz I found in my use case the old edge javascript engine wasn't handling the exception like other browsers and my it wasn't reaching my automated error reporting.

@davidbgk
Copy link

Same here, we had to downgrade to 1.7.3 to continue being Edge-compatible.

@kjcpaas
Copy link

kjcpaas commented Sep 1, 2020

We have also downgraded to an older version. Will keep watch on this PR.

Thanks for working on it! 😄

@tobloef
Copy link

tobloef commented Jul 9, 2021

Seems like the Travis CI timed out. @tofumatt, can we maybe re-run it, so we can get this merged? If it's a bug in the PR, I will happily fix it if I can get a little more info on what's going wrong.

@ronnix
Copy link

ronnix commented Aug 23, 2021

Is there a way we can help move this forward? @banjerluke maybe you can rebase your fork on the current master branch to resolve the conflicts? Hopefully Travis will then successfully run the tests 🤞

To support legacy browsers like Edge 18. Fixes localForage#970.
@banjerluke
Copy link
Author

OK, rebased onto master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS Edge 18 Object doesn't support property or method 'openKeyCursor'
9 participants