Fixed #63: Support HTTPX params argument #81
Merged
+175
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundberg
requested changes
Oct 1, 2020
|
Ticks one feature of #79 |
|
FYI @jocke-l , Still, your current |
lundberg
reviewed
Oct 1, 2020
This was referenced Oct 2, 2020
Closed
jocke-l
force-pushed
the
feature/api-params
branch
5 times, most recently
from
dfc9027 to
4d60bee
Compare
|
Let's do the final touches to simplify our code in |
Closed
jocke-l
force-pushed
the
feature/api-params
branch
2 times, most recently
from
90c0ada to
f4992f8
Compare
jocke-l
commented
Oct 10, 2020
jocke-l
force-pushed
the
feature/api-params
branch
2 times, most recently
from
6b02739 to
4ded5f7
Compare
lundberg
requested changes
Oct 10, 2020
jocke-l
force-pushed
the
feature/api-params
branch
from
9b0852f to
24088f6
Compare
jocke-l
force-pushed
the
feature/api-params
branch
2 times, most recently
from
6956203 to
314b021
Compare
jocke-l
commented
Oct 12, 2020
jocke-l
force-pushed
the
feature/api-params
branch
from
314b021 to
a82892a
Compare
lundberg
requested changes
Oct 13, 2020
jocke-l
force-pushed
the
feature/api-params
branch
from
a82892a to
d63f338
Compare
lundberg
added a commit
that referenced
this pull request
Oct 15, 2020
Added - Added `text`, `html` and `json` content shorthands to ResponseTemplate. (PR #82) - Added `text`, `html` and `json` content shorthands to high level API. (PR #93) - Added support to set `http_version` for a mocked response. (PR #82) - Added support for mocking by lowercase http methods, thanks @lbillinghamtn. (PR #80) - Added query `params` to align with HTTPX API, thanks @jocke-l. (PR #81) - Easier API to get request/response from call stats, thanks @SlavaSkvortsov. (PR #85) - Enhanced test to verify better content encoding by HTTPX. (PR #78) - Added Python 3.9 to supported versions and test suite, thanks @jairhenrique. (PR #89) Changed - `ResponseTemplate.content` as proper getter, i.e. no resolve/encode to bytes. (PR #82) - Enhanced headers by using HTTPX Response when encoding raw responses. (PR #82) - Deprecated `respx.stats` in favour of `respx.calls`, thanks @SlavaSkvortsov. (PR #92) Fixed - Recorded requests in call stats are pre-read like the responses. (PR #86) - Postponed request decoding for enhanced performance. (PR #91) - Lazy call history for enhanced performance, thanks @SlavaSkvortsov. (PR #92) Removed - Removed auto setting the `Content-Type: text/plain` header. (PR #82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
paramsargument (#63) torespx.addand it's shortcuts. It does so by using httpx.QueryParams which seems to be "publicly" exposed. I'm open for other solutions too, but I think it's easier to be on par with httpx' API this way.It also makes all other parameter except
methodandurlkeyword-only arguments, which means this code may break existing test suites. The reason for this is to be able to arrange the arguments in a natural way and avoid further backward incompatibilities in the future.