Refactor encode/decode raw response #82
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
===========================================
+ Coverage 99.46% 100.00% +0.53%
===========================================
Files 11 11
Lines 1130 1172 +42
Branches 74 80 +6
===========================================
+ Hits 1124 1172 +48
+ Misses 5 0 -5
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
| # Pre-read response, but only if mocked, not pass-through streams streams | ||
| if response and not isinstance( | ||
| response.stream, (SyncByteStream, AsyncByteStream) | ||
| ): | ||
| response.read() |
There was a problem hiding this comment.
I've moved the response auto reading from decode_response, previously build_response, to here since the pre-read is only for easier stats and recording.
I also needed to reverse the stream type check now that we rely on HTTPX streams and not our own ContentStream, which now is dropped.
@bhumilsarvaiya, could you please try this PR and verify that pass through requests still works as expected, like #68 fixed.
| @pytest.mark.skipif( | ||
| os.environ.get("PASS_THROUGH") is None, reason="External pass-through disabled" | ||
| ) | ||
| @pytest.mark.asyncio | ||
| async def test_external_pass_through(client): # pragma: nocover |
There was a problem hiding this comment.
Added a test case for a real external pass-through call, for easier testing/verifying that #68 still works.
The test is skipped by default, to not call remote, but can be run individually with:
$ PASS_THROUGH=1 nox -s test -- -k test_external_pass_throughPass-through responses still seams to work, but a second pair of eyes is appreciated @bhumilsarvaiya ;-)
lundberg
force-pushed
the
text-html-json
branch
from
34ffed2 to
94672fa
Compare
Added - Added `text`, `html` and `json` content shorthands to ResponseTemplate. (PR #82) - Added `text`, `html` and `json` content shorthands to high level API. (PR #93) - Added support to set `http_version` for a mocked response. (PR #82) - Added support for mocking by lowercase http methods, thanks @lbillinghamtn. (PR #80) - Added query `params` to align with HTTPX API, thanks @jocke-l. (PR #81) - Easier API to get request/response from call stats, thanks @SlavaSkvortsov. (PR #85) - Enhanced test to verify better content encoding by HTTPX. (PR #78) - Added Python 3.9 to supported versions and test suite, thanks @jairhenrique. (PR #89) Changed - `ResponseTemplate.content` as proper getter, i.e. no resolve/encode to bytes. (PR #82) - Enhanced headers by using HTTPX Response when encoding raw responses. (PR #82) - Deprecated `respx.stats` in favour of `respx.calls`, thanks @SlavaSkvortsov. (PR #92) Fixed - Recorded requests in call stats are pre-read like the responses. (PR #86) - Postponed request decoding for enhanced performance. (PR #91) - Lazy call history for enhanced performance, thanks @SlavaSkvortsov. (PR #92) Removed - Removed auto setting the `Content-Type: text/plain` header. (PR #82)
Refactors encoding and decoding of raw responses by using
httpx.Response.Enables support for creating response templates with
content,text,htmlandjsonbody variants.Public api and
MockTransportcan easily be extended with these "body" args in a separate PR, but probably after #81 which restrictingkwargsin api methods.