Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependencies #35

wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jul 26, 2020

No description provided.

@orgads
Copy link
Contributor Author

orgads commented Jul 26, 2020

Do you really need to support Node v4? :/

@mafintosh
Copy link
Owner

Is there any of the versions not supported on 4 or are you referring to something else?

@orgads
Copy link
Contributor Author

orgads commented Jul 26, 2020

Yes, through2 v4.

@jimmywarting
Copy link

Would like to ask: do you still want to support node version below 12?

@mafintosh
Copy link
Owner

We’ll drop that and bump major when there is a bug fix that requires it :)

@jimmywarting
Copy link

jimmywarting commented Sep 20, 2021

We’ll drop that and bump major when there is a bug fix that requires it :)

So never then 😝

How about i make a PR that modernize the code?

  • const, let, class
  • require new keyword
  • using built in stream to always get latest updates with support for async iterator
  • including this PR that updates all dependencies (doe this is probably outdated now)
  • remove Buffer constructor (or possible switch to using Uint8array instead)
  • removes the legacy inherits
  • switch to ESM-only
  • using node: prefix

@mafintosh
Copy link
Owner

Sure, as long as it's Node 10+ and keep the test devs old tho (ie concat stream) so we know we don't break anything.

@jimmywarting
Copy link

so without ESM or node: prefix then... sure i can make such PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants