Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize codebase #38

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

jimmywarting
Copy link

@jimmywarting jimmywarting commented Sep 20, 2021

Summary:

  • Updated all dep
  • Switched to const, let, class + extend
  • removed inherits and writable-stream
  • depends on builtin stream + buffer instead of polyfill (to always get newest version and fewer dependency installs)
  • tested using standard --fix index.js && npx node@10 index.js && npm run test
  • The hole test file remains the same to prove that everything works as before (only change was to use node:stream instead)
  • know you use standard.js in some projects so i applied it using latest (16) version
  • it no longer use new Buffer() constructor
  • update code examples in readme

closes #35
closes #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer() without a new keyword is going to be hard-deprecated soon
1 participant