Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize codebase #38

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Modernize codebase #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6a922fd
rm inherit
jimmywarting Sep 20, 2021
2e0de65
convert to class
jimmywarting Sep 20, 2021
116d447
proxy for backward comp
jimmywarting Sep 20, 2021
6757bd0
update dep
jimmywarting Sep 20, 2021
a1d6bcd
standard --fix
jimmywarting Sep 20, 2021
e0d56d2
default args
jimmywarting Sep 20, 2021
5941840
destruct
jimmywarting Sep 20, 2021
e63cf66
got rid of noop
jimmywarting Sep 20, 2021
0a2e8e8
rm self variable
jimmywarting Sep 20, 2021
cad429d
standard fix, remove some `const`
jimmywarting Sep 20, 2021
2b1eec2
fix long lines
jimmywarting Sep 20, 2021
4b2d8b4
use built in stream
jimmywarting Sep 20, 2021
aa593dc
no undef buf
jimmywarting Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
var duplexify = require('duplexify')
var http = require('http')
const duplexify = require('duplexify')
const http = require('http')

var request = function(opts) {
var req = http.request(opts)
var dup = duplexify()
const request = function (opts) {
const req = http.request(opts)
const dup = duplexify()
dup.setWritable(req)
req.on('response', function(res) {
req.on('response', function (res) {
dup.setReadable(res)
})
return dup
}

var req = request({
const req = request({
method: 'GET',
host: 'www.google.com',
port: 80
Expand Down